fix(util-format-url): remove headers or path from input #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neither `path` or `headers` is required for generating url string, so remove them from input parameter
trivikr
approved these changes
Oct 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #1639 +/- ##
=======================================
Coverage 79.77% 79.77%
=======================================
Files 325 325
Lines 12087 12087
Branches 2553 2553
=======================================
Hits 9643 9643
Misses 2444 2444
Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither
pathorheadersis required for generating url string, so remove them from input parameterBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.