Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package.json): migrate @aws-sdk/types into devDependencies codegen #1658

Merged

Conversation

alexforsyth
Copy link
Contributor

Issue #, if available:
Addressing issue here: #1649

Smithy typescript changes: smithy-lang/smithy-typescript#232
Code generation for
Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alexforsyth
Copy link
Contributor Author

Attempting to figure out why the build failed. It is working locally

@alexforsyth
Copy link
Contributor Author

Codebuild failed due to: #1539

@codecov-io
Copy link

Codecov Report

Merging #1658 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1658      +/-   ##
==========================================
- Coverage   79.77%   79.68%   -0.10%     
==========================================
  Files         325      327       +2     
  Lines       12087    12545     +458     
  Branches     2553     2663     +110     
==========================================
+ Hits         9643     9997     +354     
- Misses       2444     2548     +104     
Impacted Files Coverage Δ
...tocol_tests/aws-restxml/commands/XmlMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...col_tests/aws-restjson/commands/JsonMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlAttributesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlNamespacesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84d13fe...aae205f. Read the comment docs.

@alexforsyth
Copy link
Contributor Author

Using empty commit to re kick off build. Will merge if everything passes

@alexforsyth
Copy link
Contributor Author

Codebuild passed. Merging. Travis CI is not relevant here

@alexforsyth alexforsyth merged commit eb50962 into aws:master Nov 5, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants