Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node-http-handler): set maxSockets above 0 in test #1660

Merged
merged 1 commit into from
Nov 5, 2020
Merged

fix(node-http-handler): set maxSockets above 0 in test #1660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/node-http-handler/src/node-http-handler.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ import {
describe("NodeHttpHandler", () => {
describe("constructor", () => {
it("can set httpAgent and httpsAgent", () => {
let maxSockets = Math.round(Math.random() * 50);
let maxSockets = Math.round(Math.random() * 50) + 1;
trivikr marked this conversation as resolved.
Show resolved Hide resolved
trivikr marked this conversation as resolved.
Show resolved Hide resolved
let nodeHttpHandler = new NodeHttpHandler({
httpAgent: new http.Agent({ maxSockets }),
});
expect((nodeHttpHandler as any).httpAgent.maxSockets).toEqual(maxSockets);
maxSockets = Math.round(Math.random() * 50);
maxSockets = Math.round(Math.random() * 50) + 1;
trivikr marked this conversation as resolved.
Show resolved Hide resolved
nodeHttpHandler = new NodeHttpHandler({
httpsAgent: new https.Agent({ maxSockets }),
});
Expand Down