Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): re-add retry headers for QLDB and Pinpoint SMS Voice #1934

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 20, 2021

Issue #, if available:
Follow-up to #1789

Description of changes:
Adding retry headers for services which now support them: QLDB and Pinpoint SMS Voice.

Verified that access-control-allow-headers includes amz-sdk-invocation-id and amz-sdk-request for QLDB and Pinpoint SMS voice.

QLDB
$ curl --insecure -i -X OPTIONS https://qldb.us-east-1.amazonaws.com/ledgers/stringvalue/journal-kinesis-streams/stringvalue -H "User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36" -H "Origin: https://foo.example" -H "Access-Control-Request-Method: DELETE" -H "Access-Control-Request-Headers: user-agent,host,Authorization,amz-sdk-invocation-id,amz-sdk-request,x-amz-security-token" -H "host: qldb.us-east-1.amazonaws.com"


HTTP/2 200 
content-type: application/json
content-length: 0
date: Wed, 20 Jan 2021 02:04:48 GMT
x-amzn-requestid: 57eadc09-1cdd-4f06-8f30-3e3f6bf03054
access-control-allow-origin: *
access-control-allow-headers: Content-Type,X-Amz-Date,Authorization,X-Api-Key,X-Amz-Security-Token,X-Amz-Content-Sha256,X-Amz-User-Agent,amz-sdk-invocation-id,amz-sdk-request
x-amz-apigw-id: ZbNmCGQkoAMFleQ=
access-control-allow-methods: DELETE,GET
x-amzn-trace-id: Root=1-60078fc0-13216629434b012875b05c31
x-cache: Miss from cloudfront
via: 1.1 7f5e0d3b9ea85d0d75063a66c0ebc841.cloudfront.net (CloudFront)
x-amz-cf-pop: HIO50-C1
x-amz-cf-id: 9Y0r3acAOy0mSIbvpmtUhK2WxX666Wz_0wlmW9ADX0cidow7QojgGg==
Pinpoint SMS Voice
$ curl --insecure -i -X OPTIONS https://sms-voice.pinpoint.us-east-1.amazonaws.com/v1/sms-voice/configuration-sets -H "User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36" -H "Origin: https://foo.example" -H "Access-Control-Request-Method: POST" -H "Access-Control-Request-Headers: content-type,user-agent,content-length,host,Authorization,amz-sdk-invocation-id,amz-sdk-request,x-amz-security-token" -H "host: sms-voice.pinpoint.us-east-1.amazonaws.com"


HTTP/2 200 
content-type: application/json
content-length: 3
date: Wed, 20 Jan 2021 02:06:10 GMT
x-amzn-requestid: d4920a9c-3f6a-436e-8b32-54e4ef0b78e0
access-control-allow-origin: *
access-control-allow-headers: Content-Type,X-Amz-Date,Authorization,X-Api-Key,X-Amz-Content-Sha256,X-Amz-User-Agent,amz-sdk-invocation-id,amz-sdk-request
x-amz-apigw-id: ZbNy4F4uIAMFRVA=
access-control-allow-methods: GET,POST,PUT,DELETE,OPTIONS
x-cache: Miss from cloudfront
via: 1.1 bc24eca5e5d9f4acf2b3c88b0346cbb9.cloudfront.net (CloudFront)
x-amz-cf-pop: HIO50-C2
x-amz-cf-id: O4l9J-1yCzCYWIZD0R5xG1AaK2Sj_DxsUUH8eKJ0FBCf_SIL4sa6DQ==

{}

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: df74cef
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit e11909b into aws:master Jan 20, 2021
@trivikr trivikr deleted the re-add-headers-qldb-pinpoint branch January 20, 2021 17:45
@github-actions
Copy link

github-actions bot commented Feb 4, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants