fix(generate-clients): call mergeManifest when constructor.name is Object

[trivikr]

Issue #, if available:
Refs: #1919 (comment)

Description of changes:
In #1919, we decided to use downlevel-dts to create type definition files which support TS 3.4 or later. The configuration for typesVersions contains an array which is replaced to an object by out copy-to-clients script as it returns true for typeof operation.

This PR changes the typeof check to constructor.name so that only objects are replaced in package.json

$ node
Welcome to Node.js v14.15.4.
Type ".help" for more information.
> const arr = ["arr"];
undefined
> typeof arr
'object'
> arr.constructor.name
'Array'
> const obj = {"obj": "obj"};
undefined
> typeof obj
'object'
> obj.constructor.name
'Object'
> const str = "str";
undefined
> typeof str
'string'
> str.constructor.name
'String'

Testing:
Verified that generate-clients doesn't update any package.json because of this change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[aws-sdk-js-automation]

AWS CodeBuild CI Report

• CodeBuild project: sdk-staging-test
• Commit ID: beafa0e
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[codecov-io]

Codecov Report

Merging #1937 (beafa0e) into master (f2a47e8) will increase coverage by 0.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1937      +/-   ##
==========================================
+ Coverage   79.30%   79.83%   +0.52%     
==========================================
  Files         368      368              
  Lines       15132    15553     +421     
  Branches     3222     3368     +146     
==========================================
+ Hits        12001    12417     +416     
- Misses       3131     3136       +5     

Impacted Files	Coverage Δ
packages/util-waiter/src/utils/validate.ts	81.81% <0.00%> (-18.19%)	⬇️
lib/storage/src/data-chunk/readable-helper.ts	86.84% <0.00%> (-5.47%)	⬇️
packages/s3-request-presigner/src/getSignedUrl.ts	92.85% <0.00%> (-2.98%)	⬇️
packages/util-dynamodb/src/convertToAttr.ts	98.70% <0.00%> (-1.30%)	⬇️
packages/util-waiter/src/poller.ts	100.00% <0.00%> (ø)
packages/util-waiter/src/waiter.ts	100.00% <0.00%> (ø)
protocol_tests/aws-ec2/endpoints.ts	81.48% <0.00%> (ø)
protocol_tests/aws-json/endpoints.ts	81.48% <0.00%> (ø)
protocol_tests/aws-query/endpoints.ts	81.48% <0.00%> (ø)
packages/util-dynamodb/src/marshall.ts	100.00% <0.00%> (ø)
... and 156 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e11909b...beafa0e. Read the comment docs.

[alexforsyth]

LGTM

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.