fix(middleware-signing): memoize temporary credentials #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexforsyth
reviewed
Mar 11, 2021
| if (typeof credentials === "function") { | ||
| return memoize( | ||
| credentials, | ||
| (credentials) => credentials.expiration !== undefined && credentials.expiration.getTime() - Date.now() < 300000, |
There was a problem hiding this comment.
can we pull this magic number into a named const?
AllanZhengYP
force-pushed
the
fix-refresh-creds
branch
from
5196f40
to
177c709
Compare
Codecov Report
@@ Coverage Diff @@
## main #2109 +/- ##
=======================================
Coverage ? 78.68%
=======================================
Files ? 380
Lines ? 16080
Branches ? 3444
=======================================
Hits ? 12653
Misses ? 3427
Partials ? 0 Continue to review full report at Codecov.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This was referenced Mar 12, 2021
chore(deps-dev): bump @aws-sdk/client-cloudformation from 3.4.1 to 3.8.1
jamesmbourne/aws4-axios#141
Closed
Closed
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #2107
Description
It turns out not difficult to fix. When resolving the credentails in the
resolveAwsAuthConfig(), if the user supplies a customer credential provider, the client will memoize the resolved value. If the resolved value is expired, the credential will be reloaded. If the credential provider only returns a static credential(never expires), the credential will keep memoized.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.