-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiate server serde #2220
Differentiate server serde #2220
Conversation
5edc2dd
to
f43b0a2
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know how I overlooked this PR.
...n/src/main/java/software/amazon/smithy/aws/typescript/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
f43b0a2
to
b9ef262
Compare
Codecov Report
@@ Coverage Diff @@
## main #2220 +/- ##
=======================================
Coverage ? 60.09%
=======================================
Files ? 472
Lines ? 24862
Branches ? 5887
=======================================
Hits ? 14941
Misses ? 9921
Partials ? 0 Continue to review full report at Codecov.
|
b9ef262
to
69d5a2f
Compare
69d5a2f
to
40d115a
Compare
This adds differentation for empty body behavior in restJson1. For responses this protocol requires always sending an empty json object if there is some shape defined as output but nothing bound to the body or payload.
b37a3e1
to
be97d8e
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This adds differentation for empty body behavior in restJson1. For
responses this protocol requires always sending an empty json object
if there is some shape defined as output but nothing bound to the
body or payload.
Additional context
depends on: smithy-lang/smithy-typescript#305
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.