Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate server serde #2220

Merged
merged 4 commits into from
May 12, 2021

Conversation

JordonPhillips
Copy link
Member

This adds differentation for empty body behavior in restJson1. For
responses this protocol requires always sending an empty json object
if there is some shape defined as output but nothing bound to the
body or payload.

Additional context

depends on: smithy-lang/smithy-typescript#305


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: f43b0a2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@adamthom-amzn adamthom-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know how I overlooked this PR.

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@f164177). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head b37a3e1 differs from pull request most recent head be97d8e. Consider uploading reports for the commit be97d8e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2220   +/-   ##
=======================================
  Coverage        ?   60.09%           
=======================================
  Files           ?      472           
  Lines           ?    24862           
  Branches        ?     5887           
=======================================
  Hits            ?    14941           
  Misses          ?     9921           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f164177...be97d8e. Read the comment docs.

@JordonPhillips JordonPhillips changed the base branch from ssdk to main April 29, 2021 16:08
This adds differentation for empty body behavior in restJson1. For
responses this protocol requires always sending an empty json object
if there is some shape defined as output but nothing bound to the
body or payload.
@JordonPhillips JordonPhillips merged commit deed209 into aws:main May 12, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants