Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(clients): use interface for client input and resolved config #2270

Merged
merged 1 commit into from Apr 20, 2021

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Apr 16, 2021

Description

This change improves the readability of client constructor interface.

Currently there's no way to get full list of client constructor parameter, because the options split into different modularized packages:
beforeInterface

After the change, we will have full list of available options for client constructor and resolved config:
afterInterface

Testing

Tested locally


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: da68d81
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP AllanZhengYP merged commit 9ab71e8 into aws:main Apr 20, 2021
AllanZhengYP added a commit to AllanZhengYP/aws-sdk-js-v3 that referenced this pull request Apr 23, 2021
This is a follow up to aws#2270 for the newly generated clients
trivikr pushed a commit that referenced this pull request Apr 28, 2021
…2304)

This is a follow up to #2270 for the newly generated clients
@github-actions
Copy link

github-actions bot commented May 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants