Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packages): use HashConstructor instead of { new: Hash } #2638

Merged
merged 1 commit into from Aug 5, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 4, 2021

Issue

N/A

Description

Uses existing HashConstructor interface instead of { new (): Hash }

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: a9eb73e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@f01142c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2638   +/-   ##
=======================================
  Coverage        ?   60.64%           
=======================================
  Files           ?      515           
  Lines           ?    27672           
  Branches        ?     6797           
=======================================
  Hits            ?    16783           
  Misses          ?    10889           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f01142c...a9eb73e. Read the comment docs.

@trivikr trivikr merged commit 6890a47 into aws:main Aug 5, 2021
@trivikr trivikr deleted the use-hash-constructor branch August 5, 2021 00:39
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants