fix(md5-js): call fromUtf8 from correct environment #2641
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #2640
Description
Calls fromUtf8 from correct environment in md5-js
Testing
Added console.log as follows:
packages/util-utf8-browser/src/index.ts
packages/util-utf8-node/src/index.ts
import { fromArrayBuffer, fromString } from "@aws-sdk/util-buffer-from"; export const fromUtf8 = (input: string): Uint8Array => { + console.log("util-utf8-node"); const buf = fromString(input, "utf8"); return new Uint8Array(buf.buffer, buf.byteOffset, buf.byteLength / Uint8Array.BYTES_PER_ELEMENT); };
Test code
Node.js
Browser
Created bundle using webpack
Copied code from
dist/main.js
and pasted it in browser.Verified that the following was printed in console:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.