Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): remove build step prior to test #2654

Merged
merged 2 commits into from Aug 12, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 10, 2021

Issue

Noticed while working on #2653
Change which introduced ts-jest #2088

Description

The build step is not required prior to running tests, as we now use ts-jest for testing which transpiles the test code before running it.

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@4be9ec6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2654   +/-   ##
=======================================
  Coverage        ?   60.64%           
=======================================
  Files           ?      516           
  Lines           ?    27774           
  Branches        ?     6825           
=======================================
  Hits            ?    16844           
  Misses          ?    10930           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4be9ec6...97fae8e. Read the comment docs.

@trivikr trivikr force-pushed the remove-build-step-from-test branch from be21a3d to 97fae8e Compare August 10, 2021 16:44
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 97fae8e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit af23369 into aws:main Aug 12, 2021
@trivikr trivikr deleted the remove-build-step-from-test branch August 12, 2021 01:24
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants