feat(codegen): support malformed request tests #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
force-pushed
the
more-testing
branch
from
4648137
to
5124924
Compare
Codecov Report
@@ Coverage Diff @@
## main #2695 +/- ##
=======================================
Coverage ? 61.30%
=======================================
Files ? 537
Lines ? 27446
Branches ? 6698
=======================================
Hits ? 16827
Misses ? 10619
Partials ? 0 Continue to review full report at Codecov.
|
|
Is main failing? iirc that codebuild test only runs the already-generated TS code, which this doesn't touch |
gosar
approved these changes
Aug 20, 2021
AllanZhengYP
approved these changes
Aug 20, 2021
JordonPhillips
force-pushed
the
more-testing
branch
from
5124924
to
f8cd27c
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
n/a
Description
This adds suppressions for a number of malformed request tests which are known to fail currently.
Testing
Built
mainon the smithy repo and ran the malformed request tests.Additional context
Malformed request tests exist for testing the SSDK against requests that should be rejected by virtue of being malformed in some way. For instance, there are a number of tests asserting strict timestamp handling behavior that isn't implemented yet.
The tests in question are still awaiting release in the next version of Smithy, but since the actual traits and supporting infrastructure were released in 1.11.0 we can do this now so that upgrading the code generator to the next version of Smithy is painless.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.