fix(lib-storage): add missing return keys #2700
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2700 +/- ##
===========================================
- Coverage 75.19% 58.73% -16.46%
===========================================
Files 474 571 +97
Lines 20721 30629 +9908
Branches 4755 7543 +2788
===========================================
+ Hits 15581 17991 +2410
- Misses 5140 12638 +7498
Continue to review full report at Codecov.
|
|
any idea if this is slotted to make its way into a release at some point? Not to be impatient just wondering since the last activity was 26 days ago |
lib/lib-storage/src/Upload.ts
Outdated
|
|
||
| let Location: string; | ||
| if (this.client.config.forcePathStyle) { | ||
| Location = `${endpoint.protocol}//${endpoint.hostname}/${locationBucket}/${locationKey}`; |
There was a problem hiding this comment.
I did some playing around with endpoint.path -> but couldn't quite figure out it's behavior, not sure if this needs adjusting.
Sorry - no clue 🤷♂️ I'm just a contributor not a maintainer |
fair enough haha. Exciting to see some movement on this. If you end up needing a hand hit me back and maybe I'll take a look at this. I'm tired of having to skip the Renovate PRs around this dependency 🙃 |
|
@Linkgoron @ajredniwja can this PR get some attention again? It's actually embarassing that this migration option for the upload has been broken for so long. |
I'm not a part of the AWS team... |
I wouldn't have phrased it this way but in sentiment I agree. Is there anything I can do to help expedite this as I'd really like to remove the version lock I have to get around it. Is it just that we're waiting on maintainers to come back through? |
|
Would it be possible to approve this PR? This is really annoying behavior... |
@AlbanDurrheimer As I've already stated elsewhere, please don't ping me... I'm not a part of the team (nor was I ever) and I don't have any merge capabilities or anything like that. Sadly, it was my contribution that caused this bug, which is why I commented in the issue and in the PR, but otherwise I am unrelated to AWS. |
|
Thanks for fixing this! I maintain a wrapper library around S3 (next-s3-upload) that would benefit a ton from lib-storage. However, the library depends on the Is there anything I can do to help get this PR merged? Or, in the mean time, is there any advice for accessing Thanks again for fixing this! |
|
HUZZZAHHHHHHH!
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Resolves #2694
Description
Bucket,KeyandLocationfields to the return output of lib-storage when PUT is used.Testing
How was this change tested?
Additional context
I took the format of the location key from a v3.25 Upload and used it to form the logic for the string creation.
Location: 'https://kickoff-dev-serverlessdeploymentbucket-fzcuxfqyzlsl.s3.ap-southeast-2.amazonaws.com/test',By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.