Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(property-provider): do not make extra provider calls when concurrent #2716

Merged
merged 3 commits into from
Aug 27, 2021

Conversation

AllanZhengYP
Copy link
Contributor

Description

This change fix a regression introduced in #2680. It was caused by the code I removed without understanding the purpose: #2680 (comment). The bug will cause the provider being invoked multiple times before being cached.

With this change, I port back that feature that provider will only be executed once during concurrent calls. The unit test now has better description to prevent being removed.

Testing

Unit test, Manual test.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@4f02b78). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2716   +/-   ##
=======================================
  Coverage        ?   60.84%           
=======================================
  Files           ?      535           
  Lines           ?    27917           
  Branches        ?     6852           
=======================================
  Hits            ?    16987           
  Misses          ?    10930           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f02b78...45e94bb. Read the comment docs.

packages/property-provider/src/memoize.ts Outdated Show resolved Hide resolved
packages/property-provider/src/memoize.ts Outdated Show resolved Hide resolved
Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
@AllanZhengYP AllanZhengYP merged commit f9aa15e into aws:main Aug 27, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2021
@AllanZhengYP
Copy link
Contributor Author

We notice some customers are getting intermittent failures while fetching credentials from STS. This issue became more prevalent in US-EAST-1 region using Amazon EKS managed AWS Identity and Access Management (IAM) OpenID Connect (OIDC) external identity provider (IdP).

If you have the similar issue, please refer to the comment below for guidance of debugging:
#2680 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants