Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename internal retryModeProvider to retryMode #2717

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 26, 2021

Issue

Following standards of using the configuration name for Provider for retryMode.

Description

Renames retryModeProvider to retryMode.

Testing

Verified that API calls are successful in all three retryModes:

  • undefined, uses standard.
  • standard
  • adaptive
import { S3 } from "../aws-sdk-js-v3/clients/client-s3/dist/cjs/index.js";

const region = "us-east-1";
[undefined, "standard", "adaptive"].forEach(async (retryMode) => {
  const client = new S3({ region, retryMode, logger: console });
  await client.listBuckets({});
});

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@705de4e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2717   +/-   ##
=======================================
  Coverage        ?   61.31%           
=======================================
  Files           ?      537           
  Lines           ?    27450           
  Branches        ?     6699           
=======================================
  Hits            ?    16831           
  Misses          ?    10619           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 705de4e...79861a2. Read the comment docs.

@trivikr trivikr merged commit a42033e into aws:main Aug 26, 2021
@trivikr trivikr deleted the use-retryMode branch August 26, 2021 17:18
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants