Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients): allow setting path prefix from custom endpoints #2722

Merged
merged 3 commits into from
Aug 27, 2021

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Aug 27, 2021

Issue

Resolves: #1399
Related to: smithy-lang/smithy-typescript#406

Description

Allow the path in custom endpoints to be the prefix of RPC protocols.

Testing

Integration test

yarn test:integration-legacy                            
yarn run v1.22.10
$ cucumber-js --fail-fast
...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

150 scenarios (150 passed)
523 steps (523 passed)
1m37.017s
Done in 102.21s.

Additional context

Add any other context about the PR here.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@a42033e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2722   +/-   ##
=======================================
  Coverage        ?   61.31%           
=======================================
  Files           ?      537           
  Lines           ?    27453           
  Branches        ?     6705           
=======================================
  Hits            ?    16834           
  Misses          ?    10619           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a42033e...e45dc91. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit 990ba2f into aws:main Aug 27, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@aws-sdk/client-sns]: custom endpoint.path is not taken into account when making requests
3 participants