feat(s3): support generating endpoints from multi-region access point #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(signature-v4): support CRT version of sigv4 signer integrate with CRT for signing Sigv4A add yarn link and V4A presign unit test yarn change revert the change of dependencies address comments from Allan remove esModuleInterop class name changed remove a comment * feat: add crtSuite, and change to optimise the code format formatting crtSutie verify sigv4a signature * feat(signature-v4-crt): create crt implementation of sigv4 * feat(client-s3): support MRAP and SigV4a signer * feat(s3-request-presigner): support MRAP in presign * chore(signature-v4-crt): update dependencies * feat(middleware-bucket-endpoint): disable vpce for mrap * chore: fix bucket endpoint test after rebase * Revert "feat(middleware-bucket-endpoint): disable vpce for mrap" This reverts commit acbc92aaafc0bccda9318e5ba11bc938e3447855. Customer will get DNS error if the VPCE is not supported. But it's expected behavior * fix: address feedbacks * chore: rebase onto upstream Co-authored-by: Dengke Tang <dengket@amazon.com>
* feat(signature-v4-crt): update deps with latest upstream * feat(signature-v4-crt): use public version of SigV4a signer * feat(signature-v4-crt): skip crt signer dependency in non-Node.js runtimes
trivikr
approved these changes
Sep 2, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Customizations required to support accessing S3 multi-region access point
Testing
Unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.