Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(protocol): compare xml payload correctly #2840

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

AllanZhengYP
Copy link
Contributor

Issue

Followup to #2835
Related to smithy-lang/smithy-typescript#433

Description

Previously the protocol test won't throw if the xml payload's outmost node name is different. For example, it succeeded if payload is <Hola><name>Phreddy</name></Hola> but expected <Hello><name>Phreddy</name></Hello>. This change fixes it.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #2840 (7fe7ff1) into main (2d14c8b) will not change coverage.
The diff coverage is n/a.

❗ Current head 7fe7ff1 differs from pull request most recent head 4432122. Consider uploading reports for the commit 4432122 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2840   +/-   ##
=======================================
  Coverage   60.42%   60.42%           
=======================================
  Files         554      554           
  Lines       28886    28886           
  Branches     7072     7072           
=======================================
  Hits        17453    17453           
  Misses      11433    11433           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df7d12...4432122. Read the comment docs.

@AllanZhengYP
Copy link
Contributor Author

Fixed another issue that the client protocol test's test folder is not copied by generate-clients script.

Service test is still blocked, because the import path of the service client is messed up. Will fix it in separate PR

@AllanZhengYP
Copy link
Contributor Author

Needs smithy-lang/smithy-typescript#438 to be merged to unblock the CI.

@AllanZhengYP AllanZhengYP merged commit fb99d84 into aws:main Sep 30, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants