feat(private): add generic client aws-echo-service #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
force-pushed
the
add-generic-client
branch
from
78c17b9
to
78ec657
Compare
Codecov Report
@@ Coverage Diff @@
## main #2950 +/- ##
=======================================
Coverage 58.60% 58.60%
=======================================
Files 561 561
Lines 30272 30272
Branches 7452 7452
=======================================
Hits 17742 17742
Misses 12530 12530 Continue to review full report at Codecov.
|
trivikr
force-pushed
the
add-generic-client
branch
from
78ec657
to
d4116fc
Compare
adamthom-amzn
approved these changes
Oct 28, 2021
AllanZhengYP
approved these changes
Oct 28, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Refs: #2939
In step 1, we prefix
aws-protocoltests-to protocol tests in #2942.In step 2, the
protocol_testsfolder was renamed toprivatein #2943.In step 3, the generic client is added in new folder in this PR.
In step 4, we will run CI on generic client.
Description
Adds generic client aws-echo-service.
Testing
yarn generate-clientswithout optionnis passed.privateis set totrueinaws-echo-service/package.jsonensuring that@aws-sdk/aws-echo-servicewill not be published.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.