Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): fix lerna filter when only 1 package to test #3089

Merged
merged 1 commit into from Dec 9, 2021

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Dec 9, 2021

Description

The e2e test fails when only 1 package is supplied. This is caused by a bug with the lerna command construction. Fix it according to lerna/lerna#1846 (comment)


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP requested a review from a team as a code owner Dec 9, 2021
@AllanZhengYP AllanZhengYP requested a review from trivikr Dec 9, 2021
trivikr
trivikr approved these changes Dec 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #3089 (a6c35c3) into main (dd66d1a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3089   +/-   ##
=======================================
  Coverage   58.72%   58.72%           
=======================================
  Files         571      571           
  Lines       30620    30620           
  Branches     7541     7541           
=======================================
  Hits        17982    17982           
  Misses      12638    12638           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd66d1a...a6c35c3. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit dbbf59f into aws:main Dec 9, 2021
10 checks passed
@github-actions
Copy link

github-actions bot commented Dec 24, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants