Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename downlevel-dts to build:types:downlevel #3154

Merged
merged 3 commits into from
Jan 6, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 6, 2022

Issue

Refs: smithy-lang/smithy-typescript#486

Description

Renames npm script downlevel-dts to build:types:downlevel

Testing

Verified that build:types:downlevel generates downlevel types in both individual package as well as root.

client-acm
$ client-acm> ls dist-types/ts3.4
ls: cannot access dist-types/ts3.4: No such file or directory

$ client-acm> yarn build:types:downlevel
yarn run v1.22.17
$ downlevel-dts dist-types dist-types/ts3.4
Done in 1.67s.

$ ls dist-types/ts3.4       
ACMClient.d.ts  commands        index.d.ts  pagination  runtimeConfig.browser.d.ts  runtimeConfig.native.d.ts  waiters
ACM.d.ts        endpoints.d.ts  models      protocols   runtimeConfig.d.ts          runtimeConfig.shared.d.ts
root
$ aws-sdk-js-v3> ls clients/client-s3/dist-types/ts3.4 
ls: cannot access clients/client-s3/dist-types/ts3.4: No such file or directory

$ aws-sdk-js-v3> ls packages/abort-controller/dist-types/ts3.4
ls: cannot access packages/abort-controller/dist-types/ts3.4: No such file or directory

$ aws-sdk-js-v3> ls lib/lib-dynamodb/dist-types/ts3.4
ls: cannot access lib/lib-dynamodb/dist-types/ts3.4: No such file or directory

$  aws-sdk-js-v3> yarn build:types:downlevel
yarn run v1.22.17
$ node --es-module-specifier-resolution=node ./scripts/downlevel-dts
Done in 67.65s.

$ aws-sdk-js-v3> ls clients/client-s3/dist-types/ts3.4        
commands        index.d.ts  pagination  runtimeConfig.browser.d.ts  runtimeConfig.native.d.ts  S3Client.d.ts  waiters
endpoints.d.ts  models      protocols   runtimeConfig.d.ts          runtimeConfig.shared.d.ts  S3.d.ts

$ aws-sdk-js-v3> ls packages/abort-controller/dist-types/ts3.4
AbortController.d.ts  AbortSignal.d.ts  index.d.ts

$ aws-sdk-js-v3> ls lib/lib-dynamodb/dist-types/ts3.4
commands  DynamoDBDocumentClient.d.ts  DynamoDBDocument.d.ts  index.d.ts  pagination

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review January 6, 2022 17:19
@trivikr trivikr requested a review from a team as a code owner January 6, 2022 17:19
@trivikr trivikr changed the title chore(workspaces): rename downlevel-dts with build:types:downlevel chore: rename downlevel-dts to build:types:downlevel Jan 6, 2022
@trivikr trivikr merged commit 1e028be into aws:main Jan 6, 2022
@trivikr trivikr deleted the build-types-downlevel branch January 6, 2022 18:56
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants