Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump jest to 28.1.1 #3732

Merged
merged 4 commits into from
Jun 25, 2022

Conversation

AllanZhengYP
Copy link
Contributor

Issue

Issue number, if available, prefixed with "#"

Description

What does this implement/fix? Explain your changes.

Testing

How was this change tested?

Additional context

Add any other context about the PR here.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP
Copy link
Contributor Author

Currently the @aws-sdk/lib-storage unit test always takes 2 mins straight. I'm looking into the root cause.

@AllanZhengYP
Copy link
Contributor Author

I confirmed that process is not hang, jest spends minutes to compare the 5 MB buffer

const firstBuffer = largeBuffer.subarray(0, partSize);
. I will replace it with comparing hash of them.

@AllanZhengYP AllanZhengYP changed the title [DRAFT]chore(deps-dev): bump jest to 28.1.1 chore(deps-dev): bump jest to 28.1.1 Jun 23, 2022
@AllanZhengYP AllanZhengYP marked this pull request as ready for review June 23, 2022 22:03
@AllanZhengYP AllanZhengYP requested a review from a team as a code owner June 23, 2022 22:03
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to block this PR, as CI has been failing.

@AllanZhengYP AllanZhengYP merged commit f810679 into aws:main Jun 25, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants