fix(lib-dynamodb): pass lib Command middleware to client Commands #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
supercedes #3748 |
kuhe
changed the title
kuhe
force-pushed
the
3095-lib-dynamodb
branch
2 times, most recently
from
1ade74a
to
02c1ab2
Compare
kuhe
commented
Jul 7, 2022
| const { marshallOptions, unmarshallOptions } = configuration.translateConfig || {}; | ||
| const command = new __QueryCommand(marshallInput(this.input, this.inputKeyNodes, marshallOptions)); | ||
| const handler = command.resolveMiddleware(clientStack, configuration, options); | ||
| const command = new __QueryCommand(this.input); |
There was a problem hiding this comment.
add ts-ignore for future possibility of a command with non-optional fields
|
discussed with team in a review document, here's what we want to do with the PR:
|
2 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3095
Description
.clientMiddlewareStackto lib-dynamodb commands. This stack will be applied to the underlying client middleware as it is initialized..middlewareStackfrom extending smithyCommandis not usable because it implies IO types that will not actually appear in the middleware at runtime (the marshalled types).Testing