Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not append to undefined/null header values #388

Merged
merged 2 commits into from Nov 4, 2019

Conversation

Amplifiyer
Copy link
Contributor

Issue #, if available: N/A

Description of changes:
Avoid appending to user agent header when the existing value is undefined or null to avoid getting header values as "undefined myUserAgent"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #388 into master will decrease coverage by 7.98%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage     100%   92.01%   -7.99%     
==========================================
  Files           5      122     +117     
  Lines          72     3170    +3098     
  Branches       18      714     +696     
==========================================
+ Hits           72     2917    +2845     
- Misses          0      253     +253
Impacted Files Coverage Δ
packages/util-user-agent-browser/src/index.ts 90.9% <100%> (ø)
...ackages/protocol-json-rpc/src/JsonRpcSerializer.ts 100% <0%> (ø)
packages/signature-v4/src/constants.ts 100% <0%> (ø)
packages/xml-builder/src/XmlText.ts 100% <0%> (ø)
packages/json-builder/src/operations.fixtures.ts 100% <0%> (ø)
packages/url-parser-node/src/index.ts 72.72% <0%> (ø)
packages/protocol-json-rpc/src/JsonRpcParser.ts 100% <0%> (ø)
...dleware-sdk-glacier/src/add-glacier-api-version.ts 100% <0%> (ø)
...ackages/http-serialization/src/requests.fixture.ts 100% <0%> (ø)
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd0fab...8d7319d. Read the comment docs.

Co-Authored-By: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
@trivikr trivikr merged commit c25cc66 into aws:master Nov 4, 2019
@lock
Copy link

lock bot commented Nov 11, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants