Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): reduce object copying in iterators #4198

Merged
merged 2 commits into from Nov 16, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Nov 16, 2022

Issue

#4151
paired with smithy-lang/smithy-typescript#638

split from #4194, this PR only includes codegen changes

@kuhe kuhe requested a review from a team as a code owner November 16, 2022 16:48
@kuhe kuhe force-pushed the chore/reducers-codegen-only branch from 2dde47c to 56bd775 Compare November 16, 2022 16:49
@kuhe
Copy link
Contributor Author

kuhe commented Nov 16, 2022

  • generate clients

  • build:all

  • endpoints tests

  • client unit tests

  • feature tests (cucumber)

  • client integration tests

  • manual dynamodb integration test

@trivikr trivikr changed the title chore(reducers): reduce object copying in iterators chore(clients): reduce object copying in iterators Nov 16, 2022
@kuhe kuhe merged commit 3a4588f into aws:main Nov 16, 2022
@kuhe kuhe deleted the chore/reducers-codegen-only branch November 16, 2022 17:33
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants