fix(lib-dynamodb): fix use of log filters in conjunction with DynamDBDocumentClient #4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Dec 2, 2022
| @@ -41,7 +41,8 @@ describe("DynamoDBDocumentClientCommand", () => { | |||
| expect(options).toEqual({ | |||
| name: "DocumentMarshall", | |||
| override: true, | |||
| step: "initialize", | |||
| relation: "before", | |||
| toMiddleware: "serializerMiddleware", | |||
There was a problem hiding this comment.
this isn't strictly necessary since the serializer in in the serialize stage and this was in the initialize stage, but more explicit
kuhe
commented
Dec 2, 2022
| @@ -50,7 +51,8 @@ describe("DynamoDBDocumentClientCommand", () => { | |||
| expect(options).toEqual({ | |||
| name: "DocumentUnmarshall", | |||
| override: true, | |||
| step: "deserialize", | |||
| relation: "before", | |||
| toMiddleware: "deserializerMiddleware", | |||
There was a problem hiding this comment.
safer to be explicit about this, but it was already in this order
kuhe
force-pushed
the
fix/document-client
branch
from
c62c709
to
6576c1c
Compare
kuhe
force-pushed
the
fix/document-client
branch
from
6576c1c
to
dd23c68
Compare
kuhe
force-pushed
the
fix/document-client
branch
from
1f0d8ae
to
56e9494
Compare
This was referenced Dec 2, 2022
siddsriv
approved these changes
Dec 5, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3846
Description
DynamoDBDocument client changes input and output shapes. The logger middleware calls filter functions that expect the base shapes and results in errors.
in this PR:
This ensures filtering functions are called on the original input and output shapes unaffected by dynamodbdocument marshaling.
Testing
manual Put and Query command using the dynamodbdocument client.