fix(types): changed NodeJS.ProcessEnv type to Record in node-config-provider #4319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Created issue #4329 |
froggydood
force-pushed
the
fix-types-for-non-node-envs
branch
from
a4414b2
to
2fcf7e7
Compare
yenfryherrerafeliz
approved these changes
Jan 25, 2023
kuhe
approved these changes
Jan 25, 2023
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-config-provider
Description
Changed the NodeJS.ProcessEnv type (in the node-config-provider package), to a Record<string, string | undefined> type. This removes the dependency on @types/node for the node-config-provider. This means that when the types are compiled there is no reliance on it and it can be therefore used in more non-node environments, for example cloudflare worker environments, without any type mismatches or errrors.
Testing
Changed the type of
envVarGettervariable in thefromEnv.spec.tsfile, to match the new type file. Because its only a type change, there is only minimal test changes.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.