chore(deps-dev): bump typedoc to v0.23.23 #4458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-generator plugin
…earch result's live region
Chore/bump typedoc v0.23.23
MYoung25
added
documentation
MYoung25
added a commit
to MYoung25/smithy-typescript
that referenced
this pull request
Feb 22, 2023
kuhe
approved these changes
Feb 22, 2023
|
Is this really 32 commits, or is the branch out of sync with main? |
trivikr
changed the title
trivikr
reviewed
Feb 22, 2023
| "typedoc": "0.19.2", | ||
| "typescript": "~4.6.2" | ||
| "typedoc": "^0.23.23", | ||
| "typescript": "4.7.3" |
There was a problem hiding this comment.
Can we bump typeScript in a different PR?
trivikr
reviewed
Feb 22, 2023
| @@ -95,6 +95,10 @@ | |||
| "react-native": { | |||
| "./dist-es/runtimeConfig": "./dist-es/runtimeConfig.native" | |||
| }, | |||
| "typedoc": { | |||
There was a problem hiding this comment.
The entrypoint and readmeFile is defined in typedoc.json
Is this config in package.json redundnant?
There was a problem hiding this comment.
this here is actually needed for the client SDK itself because they are generated in isolation and not in the context of the Yarn workspaces
|
Closed in favor of #4515 |
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#4134
Description
Upgrade TypeDoc to 0.23.x and implement identified a11y fixes in output
Testing
How was this change tested?
Additional context
Internal information in JS-3393, JS-4030, and CR-85945847
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.