Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accepts header middleware #473

Merged
merged 4 commits into from
Nov 27, 2019
Merged

Accepts header middleware #473

merged 4 commits into from
Nov 27, 2019

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Nov 27, 2019

Updates and applies middleware-sdk-api-gateway

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Nov 27, 2019
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@srchase
Copy link
Contributor Author

srchase commented Nov 27, 2019

Should this package get renamed? It only contains the acceptsHeaderMiddleware. Perhaps the package name should better reflect that.

@codecov-io
Copy link

codecov-io commented Nov 27, 2019 •
edited
Loading

Codecov Report

Merging #473 into smithy-codegen will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           smithy-codegen     #473   +/-   ##
===============================================
  Coverage           95.17%   95.17%           
===============================================
  Files                  72       72           
  Lines                1389     1389           
  Branches              272      272           
===============================================
  Hits                 1322     1322           
  Misses                 67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735c648...37b4e7a. Read the comment docs.

@AllanZhengYP
Copy link
Contributor

If these are specific customizations only for APIGateway, we can keep the name in case of more customizations for the service in the future

@srchase srchase merged commit afee437 into aws:smithy-codegen Nov 27, 2019
@srchase srchase deleted the accepts-header-middleware branch November 27, 2019 22:09
@lock
Copy link

lock bot commented Dec 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 4, 2019
AllanZhengYP
AllanZhengYP reviewed Jan 7, 2020
View reviewed changes
packages/middleware-sdk-api-gateway/src/index.ts
args: BuildHandlerArguments<any>
): Promise<BuildHandlerOutput<Output>> => {
let request = { ...args.request };
if (HttpRequest.isInstance(request)) {
Copy link
Contributor

@AllanZhengYP AllanZhengYP Jan 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srchase HttpRequest dependency is missing from this PR. #659 is created to fix this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

Assignees
No one assigned
Labels
smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srchase @aws-sdk-js-automation @codecov-io @AllanZhengYP