Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: stub credentialDefaultProvider in test-http-handler #4781

Merged
merged 2 commits into from Jun 21, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jun 1, 2023

this might help prevent dns lookup in integ tests with the test http handler

@kuhe kuhe requested a review from a team as a code owner June 1, 2023 22:12
@kuhe kuhe marked this pull request as draft June 1, 2023 22:14
@kuhe
Copy link
Contributor Author

kuhe commented Jun 1, 2023

the issue is due to the behavior in awsAuthConfiguration.ts

the credentials are normalized and memoized and this composed function is given to the signer. Thus the signer will always call the original credential lookup chain. One way to avoid this is to override the signer in the test http handler, but that may be too much deviation from the natural client.

@trivikr trivikr marked this pull request as ready for review June 2, 2023 00:08
@kuhe kuhe marked this pull request as draft June 2, 2023 15:48
@kuhe kuhe marked this pull request as ready for review June 2, 2023 17:04
@kuhe kuhe merged commit 20391b1 into aws:main Jun 21, 2023
3 checks passed
@kuhe kuhe deleted the test/test-http-handler branch June 21, 2023 16:04
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants