Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client-cloudfront-keyvaluestore): use sigv4a signer by default #5684

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jan 15, 2024

This PR changes the default signer to SignatureV4MultiRegion for @aws-sdk/client-cloudfront-keyvaluestore.

Without this change, to use certain features, users must manually set the signer like so:

const { SignatureV4MultiRegion } = require("@aws-sdk/signature-v4-multi-region");
require("@aws-sdk/signature-v4-crt");

const client = new CloudFrontKeyValueStoreClient({
  region: "us-east-1",
  signerConstructor: SignatureV4MultiRegion,
});

After this change is released:

require("@aws-sdk/signature-v4-crt");

const client = new CloudFrontKeyValueStoreClient({
  region: "us-east-1",
  // default signer is SignatureV4MultiRegion, no need to explicitly set it
});

@kuhe kuhe requested a review from a team as a code owner January 15, 2024 16:52
@kuhe kuhe merged commit a54f8c4 into aws:main Jan 15, 2024
3 checks passed
@kuhe kuhe deleted the fix/cfkvs-signer branch January 15, 2024 17:20
RanVaknin pushed a commit to RanVaknin/aws-sdk-js-v3 that referenced this pull request Jan 16, 2024
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants