chore(ci): add pre-commit hooks to run in CI to duplicate validation #5943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddsriv
changed the title
kuhe
approved these changes
Mar 28, 2024
kuhe
changed the title
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Internal JS-5114
Description
enables pre-commit hooks to run in CI as well to duplicate validation, in case of a commit that bypasses the pre-commit-hooks locally.
Testing
new check created and can be confirmed in the checks column.
pushed an empty commit to confirm the new check runs whenever a new commit is pushed, and it runs when a new PR is opened (both of these against the
mainbranch only).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.