Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: codegen for endpoint and hostname prefixing #777

Merged
merged 3 commits into from Jan 23, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 23, 2020

Issue #, if available:
Refs: smithy-lang/smithy-typescript#104

Description of changes:
codegen for endpoint and hostname prefixing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (smithy-codegen@3556224). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             smithy-codegen     #777   +/-   ##
=================================================
  Coverage                  ?   92.42%           
=================================================
  Files                     ?      142           
  Lines                     ?     2811           
  Branches                  ?      487           
=================================================
  Hits                      ?     2598           
  Misses                    ?      213           
  Partials                  ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3556224...893ea19. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit 7e4ac48 into aws:smithy-codegen Jan 23, 2020
@trivikr trivikr deleted the endpoint-hostname-prefixing branch January 23, 2020 21:41
@lock
Copy link

lock bot commented Jan 30, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants