feat: glacier checksum middleware #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## smithy-codegen #789 +/- ##
==================================================
+ Coverage 92.24% 92.38% +0.13%
==================================================
Files 144 147 +3
Lines 2851 2915 +64
Branches 489 509 +20
==================================================
+ Hits 2630 2693 +63
- Misses 221 222 +1
Continue to review full report at Codecov.
|
kstich
approved these changes
Jan 28, 2020
...gen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddBlobReaderDependency.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
packages/middleware-sdk-glacier/src/add-glacier-api-version.spec.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
srchase
force-pushed
the
glacier-middleware
branch
from
8054b55
to
c9c4b71
Compare
kstich
reviewed
Jan 30, 2020
...n/java/software/amazon/smithy/aws/typescript/codegen/AddBodyChecksumGeneratorDependency.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
kstich
approved these changes
Jan 30, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds addChecksumHeadersMiddleware which computes and sets x-amz-content-sha256 and x-amz-sha-256-tree-hash headers for Glacier client
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.