Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: codegen for not initializing body to empty #852

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 5, 2020

Issue #, if available:
Refs: smithy-lang/smithy-typescript#118

Description of changes:
codegen for not initializing body to empty

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

Merging #852 into smithy-codegen will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           smithy-codegen     #852   +/-   ##
===============================================
  Coverage           92.36%   92.36%           
===============================================
  Files                 147      147           
  Lines                2907     2907           
  Branches              508      508           
===============================================
  Hits                 2685     2685           
  Misses                222      222

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7865151...8bd4343. Read the comment docs.

@trivikr trivikr merged commit 4568b67 into aws:smithy-codegen Feb 5, 2020
@trivikr trivikr deleted the do-not-set-body-empty-codegen branch February 5, 2020 16:26
@lock
Copy link

lock bot commented Feb 12, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants