fix: remove test suite fixture #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## smithy-codegen #890 +/- ##
==================================================
- Coverage 92.15% 92.13% -0.02%
==================================================
Files 148 147 -1
Lines 2905 2900 -5
Branches 513 513
==================================================
- Hits 2677 2672 -5
Misses 228 228Continue to review full report at Codecov.
|
trivikr
approved these changes
Feb 8, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #862
The Signature V4 test suite fixture is built before testing using the buildSuiteFixure.js script.
This script is invoked on the pretest command and the resulting
/src/suite.fixture.tsfile should not be checked into source.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.