Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: codegen for adding react-native target #903

Merged
merged 3 commits into from
Feb 10, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 10, 2020

Issue #, if available:
Refs: smithy-lang/smithy-typescript#125

Description of changes:
codegen for adding react-native target

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@AllanZhengYP AllanZhengYP marked this pull request as ready for review February 10, 2020 22:45
@codecov-io
Copy link

codecov-io commented Feb 10, 2020

Codecov Report

Merging #903 into smithy-codegen will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           smithy-codegen     #903      +/-   ##
==================================================
- Coverage           92.18%   92.12%   -0.06%     
==================================================
  Files                 149      145       -4     
  Lines                2930     2908      -22     
  Branches              516      513       -3     
==================================================
- Hits                 2701     2679      -22     
  Misses                229      229
Impacted Files Coverage Δ
packages/signature-v4/src/suite.fixture.ts
packages/signature-v4-node/src/index.ts
packages/signature-v4-browser/src/index.ts
packages/signature-v4-universal/src/index.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 634b3f6...09659da. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit 6c0af9c into aws:smithy-codegen Feb 10, 2020
@trivikr trivikr deleted the add-react-native-target branch February 10, 2020 23:12
@lock
Copy link

lock bot commented Feb 18, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants