Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in CodeGen #905

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 10, 2020

Issue #, if available:
Fixes: #904

Description of changes:
fixes typo in CodeGen

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr merged commit 9fffc2b into aws:smithy-codegen Feb 10, 2020
@trivikr trivikr deleted the fix-generate-clients branch February 10, 2020 22:56
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

Merging #905 into smithy-codegen will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           smithy-codegen     #905      +/-   ##
==================================================
- Coverage           92.18%   92.12%   -0.06%     
==================================================
  Files                 149      145       -4     
  Lines                2930     2908      -22     
  Branches              516      513       -3     
==================================================
- Hits                 2701     2679      -22     
  Misses                229      229
Impacted Files Coverage Δ
packages/signature-v4/src/suite.fixture.ts
packages/signature-v4-node/src/index.ts
packages/signature-v4-browser/src/index.ts
packages/signature-v4-universal/src/index.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba7094b...6b686cf. Read the comment docs.

@lock
Copy link

lock bot commented Feb 18, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants