Modified rest json protocol so DELETEs no longer send body data

aws · Sep 14, 2015 · 0fd44da · 0fd44da
1 parent 3d3988e
commit 0fd44da
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/protocol/rest_json.js b/lib/protocol/rest_json.js
@@ -27,8 +27,8 @@ function populateBody(req) {
 function buildRequest(req) {
   Rest.buildRequest(req);
 
-  // never send body payload on GET/HEAD
-  if (['GET', 'HEAD'].indexOf(req.httpRequest.method) < 0) {
+  // never send body payload on GET/HEAD/DELETE
+  if (['GET', 'HEAD', 'DELETE'].indexOf(req.httpRequest.method) < 0) {
     populateBody(req);
   }
 }

diff --git a/test/protocol/rest_json.spec.coffee b/test/protocol/rest_json.spec.coffee
@@ -128,7 +128,7 @@ describe 'AWS.Protocol.RestJson', ->
         expect(request.httpRequest.headers['x-amz-meta-abc']).to.equal('xyz')
 
     describe 'body', ->
-      ['GET', 'HEAD'].forEach (method) ->
+      ['GET', 'HEAD', 'DELETE'].forEach (method) ->
         it 'does not populate a body on a ' + method + ' request', ->
           request.params = Data: 'abc'
           defop

diff --git a/test/services/elastictranscoder.spec.coffee b/test/services/elastictranscoder.spec.coffee
@@ -25,7 +25,7 @@ describe 'AWS.ElasticTranscoder', ->
       et.cancelJob { Id: 'job-id' }, (err, data) ->
         req = this.request.httpRequest
         expect(req.path).to.equal('/2012-09-25/jobs/job-id')
-        expect(req.body).to.equal('{}')
+        expect(req.body).to.equal('')
 
   describe 'updatePipelineNotifications', ->
     it 'only populates the body with non-uri and non-header params', ->