Fixes issue with binary response bodies being empty in react native (#…

…1504)
aws · May 9, 2017 · 2c1b94e · 2c1b94e
1 parent 75343e9
commit 2c1b94e
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/.changes/next-release/bugfix-ReactNative-1c146c4d.json b/.changes/next-release/bugfix-ReactNative-1c146c4d.json
@@ -0,0 +1,5 @@
+{
+  "type": "bugfix",
+  "category": "ReactNative",
+  "description": "Fixes issue where binary responses were empty in iOS (e.g. s3.getObject)"
+}
diff --git a/lib/http/xhr.js b/lib/http/xhr.js
@@ -25,7 +25,6 @@ AWS.XHRClient = AWS.util.inherit({
       } catch (e) { return; }
 
       if (this.readyState >= this.HEADERS_RECEIVED && !headersEmitted) {
-        try { xhr.responseType = 'arraybuffer'; } catch (e) {}
         emitter.statusCode = xhr.status;
         emitter.headers = self.parseHeaders(xhr.getAllResponseHeaders());
         emitter.emit(
@@ -75,6 +74,7 @@ AWS.XHRClient = AWS.util.inherit({
     if (httpOptions.xhrWithCredentials) {
       xhr.withCredentials = true;
     }
+    try { xhr.responseType = 'arraybuffer'; } catch (e) {}
 
     try {
       if (httpRequest.body) {

diff --git a/test/browser.spec.js b/test/browser.spec.js