Removed array as valid customUserAgent type

aws · Dec 3, 2015 · 4c59d58 · 4c59d58
1 parent b558464
commit 4c59d58
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/lib/http.js b/lib/http.js
@@ -109,9 +109,7 @@ AWS.HttpRequest = inherit({
   setUserAgent: function setUserAgent(customUserAgent) {
     var prefix = AWS.util.isBrowser() ? 'X-Amz-' : '';
     var customSuffix = '';
-    if (Array.isArray(customUserAgent) && customUserAgent.length) {
-      customSuffix += ' ' + customUserAgent.join('/');
-    } else if (typeof customUserAgent === 'string' && customUserAgent) {
+    if (typeof customUserAgent === 'string' && customUserAgent) {
       customSuffix += ' ' + customUserAgent;
     }
     this.headers[prefix + 'User-Agent'] = AWS.util.userAgent() + customSuffix;

diff --git a/test/http_request.spec.coffee b/test/http_request.spec.coffee
@@ -31,12 +31,6 @@ describe 'AWS.HttpRequest', ->
       request = new AWS.HttpRequest('http://domain.com', '', 'custom')
       expect(request.headers).to.eql(headers)
 
-    it 'adds the customUserAgent to the user agent header if provided as array', ->
-      headers = {}
-      headers[agentHeader] = AWS.util.userAgent() + ' custom/1'
-      request = new AWS.HttpRequest('http://domain.com', '', ['custom', 1])
-      expect(request.headers).to.eql(headers)
-
     it 'defaults body to empty string', ->
       expect(request.body).to.equal('')