Fixes AWS.S3.putBucketReplication signature errors

Related to issue #910
aws · Mar 4, 2016 · 9d08bc4 · 9d08bc4
1 parent fb13521
commit 9d08bc4
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 1 deletion.
diff --git a/lib/services/s3.js b/lib/services/s3.js
@@ -152,7 +152,8 @@ AWS.util.update(AWS.S3.prototype, {
     putBucketLifecycle: true,
     putBucketLifecycleConfiguration: true,
     putBucketTagging: true,
-    deleteObjects: true
+    deleteObjects: true,
+    putBucketReplication: true
   },
 
   /**

diff --git a/lib/signers/s3.js b/lib/signers/s3.js
@@ -20,6 +20,7 @@ AWS.Signers.S3 = inherit(AWS.Signers.RequestSigner, {
     'partNumber': 1,
     'policy': 1,
     'requestPayment': 1,
+    'replication': 1,
     'restore': 1,
     'tagging': 1,
     'torrent': 1,

diff --git a/test/services/s3.spec.coffee b/test/services/s3.spec.coffee
@@ -612,13 +612,15 @@ describe 'AWS.S3', ->
       willCompute 'putBucketLifecycle', computeChecksums: true
       willCompute 'putBucketLifecycleConfiguration', computeChecksums: true
       willCompute 'putBucketTagging', computeChecksums: true
+      willCompute 'putBucketReplication', computeChecksums: true
 
     it 'computes checksums if computeChecksums is off and operation requires it', ->
       willCompute 'deleteObjects', computeChecksums: false
       willCompute 'putBucketCors', computeChecksums: false
       willCompute 'putBucketLifecycle', computeChecksums: false
       willCompute 'putBucketLifecycleConfiguration', computeChecksums: false
       willCompute 'putBucketTagging', computeChecksums: false
+      willCompute 'putBucketReplication', computeChecksums: false
 
     it 'does not compute checksums if computeChecksums is off', ->
       willCompute 'putObject', computeChecksums: false, hash: null

diff --git a/test/signers/s3.spec.coffee b/test/signers/s3.spec.coffee
@@ -276,6 +276,17 @@ describe 'AWS.Signers.S3', ->
       /?versionId=a%2Bb
       """)
 
+    it 'includes the replication subresource without a value', ->
+      path = '/?replication'
+      expect(stringToSign()).to.equal("""
+      POST
+
+
+
+      x-amz-date:DATE-STRING
+      /?replication
+      """)
+
     it 'includes the non-encoded query string get header overrides', ->
       path = '/?response-content-type=a%2Bb' # a+b
       expect(stringToSign()).to.equal("""