Ensure req.send is not called until an error handler is registered wh…

…en creating readable streams
aws · May 8, 2017 · b6f5b65 · b6f5b65
1 parent 6929f7d
commit b6f5b65
Show file tree

Hide file tree

Showing 4 changed files with 1,208 additions and 1,136 deletions.
diff --git a/lib/request.js b/lib/request.js
@@ -565,7 +565,7 @@ AWS.Request = inherit({
 
     if (AWS.HttpClient.streamsApiVersion === 2) {
       stream = new streams.PassThrough();
-      req.send();
+      process.nextTick(function() { req.send(); });
     } else {
       stream = new streams.Stream();
       stream.readable = true;
@@ -579,6 +579,10 @@ AWS.Request = inherit({
       });
     }
 
+    this.on('error', function(err) {
+      stream.emit('error', err);
+    });
+
     this.on('httpHeaders', function streamHeaders(statusCode, headers, resp) {
       if (statusCode < 300) {
         req.removeListener('httpData', AWS.EventListeners.Core.HTTP_DATA);
@@ -652,10 +656,6 @@ AWS.Request = inherit({
       }
     });
 
-    this.on('error', function(err) {
-      stream.emit('error', err);
-    });
-
     return stream;
   },
 

diff --git a/test/helpers.js b/test/helpers.js