Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript: Interfaces for CredentialProviderChain missing resolvePromise function #1600

Closed
rhussmann opened this issue Jun 26, 2017 · 3 comments
Labels
typings Issue is related to typings.

Comments

@rhussmann
Copy link

Version: current on master

Issue
The Typescript definition doesn't define CredentialProviderChain.resolvePromise, even though it is defined in code and in the AWS JS SDK Documentation

Reference

Requested Change
Please regenerate the type definition for lib/credentials/credential_provider_chain.d.ts to include this method.

@jeskew jeskew added the typings Issue is related to typings. label Jun 28, 2017
@miikaah
Copy link

miikaah commented Jul 7, 2017

Ran into this as well. Also, the constructor's providers argument could be optional.

Right now I have to call CredentialProviderChain like this which is pretty ugly:

new AWS.CredentialProviderChain(undefined)['resolvePromise']();

@jeskew
Copy link
Contributor

jeskew commented Sep 6, 2017

This was resolved in #1655.

@jeskew jeskew closed this as completed Sep 6, 2017
@lock
Copy link

lock bot commented Sep 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typings Issue is related to typings.
Projects
None yet
Development

No branches or pull requests

3 participants