Fixes issue wherein the wrong parameter name was used for cross region presigned urls #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 similar comments
jeskew
approved these changes
Jan 25, 2017
| var doesParamValidation = !!this.config.paramValidation; | ||
| // remove the validate parameters listener so we can re-add it after we build the URL | ||
| if (doesParamValidation) { | ||
| request.removeListener('validate', AWS.EventListeners.Core.VALIDATE_PARAMETERS); |
There was a problem hiding this comment.
I wish we had a better way to reorder listeners instead of just removing and re-adding them. Changing this is out of scope for this CR, but it's something we should take a look at.
There was a problem hiding this comment.
Agreed, we do this often enough throughout the SDK that we should provide a better way to handle this.
| @@ -215,7 +215,7 @@ describe 'AWS.EventListeners', -> | |||
| makeRequest(->) | |||
| expect(options.timeout).to.equal(15) | |||
|
|
|||
| it 'signs only once in normal case', -> | |||
| it 'signs only once in normal case', (done) -> | |||
There was a problem hiding this comment.
Hopefully, making all of these async should take care of the flickering failures we've been seeing over the past few weeks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1324
/cc @jeskew