Add test and changelog entry for AWSJS_DEBUG support #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1783 +/- ##
=========================================
+ Coverage 95.7% 95.7% +<.01%
=========================================
Files 189 189
Lines 6593 6595 +2
Branches 1343 1344 +1
=========================================
+ Hits 6310 6312 +2
Misses 283 283
Continue to review full report at Codecov.
|
AllanZhengYP
approved these changes
Oct 27, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes #1739 and adds some tests and a changelog entry.
The config test file was largely unchanged since all tests were converted from coffeescript, so this PR includes one commit removing all coffeescript-specific idioms from the file and another converting it from a test suite inside an IIFE to a regular test suite.