Fixes a DocumentClient bug with the minified version of the browser SDK. #1990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where sending Sets of data with the DynamoDB DocumentClient would cause an error to be returned from the service.
Also updated the browser test task to use the minified version of the browser SDK so we should catch these problems in the future.
There was an issue occurring where trying to use
Set
s with the DynamoDBDocumentClient
would fail in the minified SDK. This is because the typeName check looked at theconstructor.name
property of a Set. Since minifying the SDK gets rid of function names, theconstructor.name
property of Sets becameconstructor
instead ofSet
.I've kept the existing check in place for native types (like typed arrays) but also check for a new property on our custom types first.