tweak CSM config to be able to enabled by only environment or config #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
force-pushed
the
client-side-monitoring-update
branch
from
adad800
to
a1c0370
Compare
Codecov Report
@@ Coverage Diff @@
## master #2480 +/- ##
==========================================
+ Coverage 96.84% 96.84% +<.01%
==========================================
Files 279 279
Lines 8500 8503 +3
Branches 1620 1621 +1
==========================================
+ Hits 8232 8235 +3
Misses 268 268
Continue to review full report at Codecov.
|
AllanZhengYP
force-pushed
the
client-side-monitoring-update
branch
from
e04f4e8
to
6295409
Compare
|
🚢 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently SDK requires user to add client config
clientSideMonitoringto enable client side monitoring feature. This indicates code change. This change makes SDK sends metrics for all the clients if corresponding environment is setup.This change is made in order to keep consistency with other SDK.
/cc @srchase
Checklist
npm run testpassesnpm run add-change