-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify global endpoint and signature region for other partitions #3274
Conversation
So far the global endpoint had `us-east-1` for normal partition hard-coded and it did not work in other partitions like China or us-gov. aws#3192
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very solid PR. It's a good start. I have a few questions in the comment
lib/request.js
Outdated
if (service.isGlobalEndpoint) { | ||
if (service.signatureRegion) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
signingRegion
can be applicable for non-global regions right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the service is non-global the signingRegion
should be equal to the region passed to the client. Either the detected region or the explicitly specified one.
lib/request.js
Outdated
if (service.isGlobalEndpoint) region = 'us-east-1'; | ||
if (service.isGlobalEndpoint) { | ||
if (service.signatureRegion) { | ||
region = service.signatureRegion; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to fix in this PR but we need to expost signingRegion
to the client config later.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has not received a response in 1 week. If you still think there is a problem, please leave a comment to avoid the PR from automatically closing. |
Hey bot! yes, the ticket is still important and all comments addressed. Please don't auto close it |
@workeitel Awesome! I'm going to approve this PR. Can you add the changelog to the PR? |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for the work!
So far the global endpoint had
us-east-1
for normal partitionhard-coded and it did not work in other partitions like China or us-gov.
#3192
Route53 endpoint pattern (source)
IAM endpoint pattern (source)
testing
script:
before:
after:
Checklist
npm run test
passesnpm run add-change