Fix createPresignedPost dual-callback error

[slifty]

This fixes a bug where using the callback version of createPresignedPost without proper AWS credentials configured would result in an un-catchable error and crash the node process.

Note: as discussed in #3486, I was not able to figure out a way to write a test to capture this error due to the nature of the error. In the original code, the callback is called correctly at first, and only after that does the crash occur (when the callback is called a second time).

Resolves #3486

Checklist

• npm run test passes
• changelog is added, npm run add-change

[ajredniwja]

Can you please address the build failure @slifty ?

[slifty]

@ajredniwja I believe that failure is because I force pushed to correct a typo in my change log that I noticed right after opening the PR, which meant the branch didn't exist any more (the error in that failure is reference not found for primary source and source version 4b64673d0e391567ab0e3a37f7bc5a437a06378e)

The fd99318 commit passed -- which is indeed the actual commit in the current PR.

Is there a way for me to trigger a re-build, or is that good enough?

[ajredniwja]

Hey @slifty we would need a successful build to review and merge this what you can do is rebase from master and push which would trigger rebuild.

git fetch upstream
git rebase upstream/master
git push --force-with-lease

[aws-sdk-js-automation]

AWS CodeBuild CI Report

• CodeBuild project: sdk-v2-github
• Commit ID: e25d497
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[slifty]

@ajredniwja Just following up on whether there are any other changes you would like?

[ajredniwja]

Apologies for late reply, Thanks for your late reply.